pull-local: Write detached metadata into the correct repository

We want to write to the dest repo, not src.

Noticed while reviewing this code for some other bug.

https://bugzilla.gnome.org/show_bug.cgi?id=733579

diff --git a/src/ostree/ot-builtin-pull-local.c b/src/ostree/ot-builtin-pull-local.c
index b5b5728fd8f7f481093f0d3d22c5384544f8e814..50b05a6f783a987d9376f787e779de9cfc4617ca 100644 (file)
--- a/src/ostree/ot-builtin-pull-local.c
+++ b/src/ostree/ot-builtin-pull-local.c
@@ -91,7 +91,7 @@ import_one_object (OtLocalCloneData *data,
 
           if (detached_meta)
             {
-              if (!ostree_repo_write_commit_detached_metadata (data->src_repo,
+              if (!ostree_repo_write_commit_detached_metadata (data->dest_repo,
                                                                checksum, detached_meta,
                                                                cancellable, error))
                 goto out;

diff --git a/tests/test-basic.sh b/tests/test-basic.sh
index e078385586a0aaffad530c3f14ebd1dbfdfd9301..5bac71c801f21268fab5c070e253883d34bc9f08 100755 (executable)
--- a/tests/test-basic.sh
+++ b/tests/test-basic.sh
@@ -326,6 +326,8 @@ rm repo2 -rf
 mkdir repo2
 ${CMD_PREFIX} ostree --repo=repo2 init
 ${CMD_PREFIX} ostree --repo=repo2 pull-local repo
+ostree --repo=repo2 show --print-detached-metadata-key=SIGNATURE test2 > test2-meta
+assert_file_has_content test2-meta "HANCOCK"
 echo "ok pull-local after commit metadata"
 
 cd ${test_tmpdir}